[POC] Support geo_point #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
| @@ -122,7 +122,7 @@ public Map<String, ExprType> lookupAllFields(Namespace namespace) { | |||
| final LinkedHashMap<String, ExprType> results = new LinkedHashMap<>(); | |||
| allSymbols.entrySet().stream().filter(entry -> { | |||
| String symbolName = entry.getKey(); | |||
| int lastDot = symbolName.lastIndexOf("."); | |||
| int lastDot = symbolName.lastIndexOf(":"); | |||
There was a problem hiding this comment.
What happens with values of object type? Isn't this breaking?
There was a problem hiding this comment.
No it gets separated into columns. This is not for geo_point support. Just to show that Tableau will work if geo_point values are separated.
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports geo_point by adding properties for lat and lon in order for Tableau to access locations.
Changes in
SymbolTableandRestSqlActionare just hacks to separate the properties of columns as separate columns.Result of changes on Tableau:
Disable aggregation on number values:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.