forked from opensearch-project/sql
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unused imports, adds new line at end of files. #287
Closed
MitchellGale
wants to merge
11
commits into
integ/fixImports_fixEndNewLine
from
dev/fixImports_fixEndNewLine
Closed
Removes unused imports, adds new line at end of files. #287
MitchellGale
wants to merge
11
commits into
integ/fixImports_fixEndNewLine
from
dev/fixImports_fixEndNewLine
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
July 11, 2023 21:36
Signed-off-by: Mitchell Gale <[email protected]>
…ject#1825) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
* Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <[email protected]> * Update IT index Signed-off-by: Andrew Carbonetto <[email protected]> * Update doctest Signed-off-by: acarbonetto <[email protected]> * Add WHERE clause IT tests Signed-off-by: acarbonetto <[email protected]> * Fix IT test Signed-off-by: acarbonetto <[email protected]> * Update documentation for _routing Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <[email protected]> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <[email protected]> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Matthew Wells <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Peng Huo <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
* Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Forest Vey <[email protected]> Co-authored-by: Matthew Wells <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
* Create Spark Connector Signed-off-by: Vamsi Manohar <[email protected]> * Add spark client and engine Signed-off-by: Rupal Mahajan <[email protected]> * Remove vars Signed-off-by: Rupal Mahajan <[email protected]> * Spark connector draft Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Fix checkstyle errors Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Fix license header Signed-off-by: Rupal Mahajan <[email protected]> * Add spark storage test Signed-off-by: Rupal Mahajan <[email protected]> * Update comments Signed-off-by: Rupal Mahajan <[email protected]> * Fix checkstyle in comments Signed-off-by: Rupal Mahajan <[email protected]> * Update tests Signed-off-by: Rupal Mahajan <[email protected]> * Add emr client Signed-off-by: Rupal Mahajan <[email protected]> * Set default values for flint args Signed-off-by: Rupal Mahajan <[email protected]> * Validate emr auth type Signed-off-by: Rupal Mahajan <[email protected]> * Add default constants for flint Signed-off-by: Rupal Mahajan <[email protected]> * Update unit tests Signed-off-by: Rupal Mahajan <[email protected]> * Address PR comments Signed-off-by: Rupal Mahajan <[email protected]> * tests draft Signed-off-by: Rupal Mahajan <[email protected]> * Refactor class name Signed-off-by: Rupal Mahajan <[email protected]> * Rename classes and update tests Signed-off-by: Rupal Mahajan <[email protected]> * Update scan operator test Signed-off-by: Rupal Mahajan <[email protected]> * Address PR comment Signed-off-by: Rupal Mahajan <[email protected]> * Fix Connection pool shut down issue Signed-off-by: Rupal Mahajan <[email protected]> * Update emr unit tests Signed-off-by: Rupal Mahajan <[email protected]> * Update doc and tests Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Update EMR clinet impl tests Signed-off-by: Rupal Mahajan <[email protected]> * Address PR comments Signed-off-by: Rupal Mahajan <[email protected]> * Make spark & flint jars configurable Signed-off-by: Rupal Mahajan <[email protected]> * Address comments Signed-off-by: Rupal Mahajan <[email protected]> * Add spark application id in logs Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Delete result when not required Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
force-pushed
the
dev/fixImports_fixEndNewLine
branch
from
July 11, 2023 21:37
a54cb11
to
cc4f7cb
Compare
MitchellGale
removed request for
GumpacG,
forestmvey,
Yury-Fridlyand,
MaxKsyunz and
acarbonetto
July 11, 2023 21:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unused imports, adds new lines at end of files that are missing them.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.