Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimmed trailing whitespace #292

Conversation

MitchellGale
Copy link

@MitchellGale MitchellGale commented Jul 12, 2023

Description

Trimmed trailing whitespace.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 5 commits July 11, 2023 20:32
Signed-off-by: Mitchell Gale <[email protected]>

Remove commented out spotless changes.

Signed-off-by: Mitchell Gale <[email protected]>

Adding Spotless to DEVELOPER_GUIDE.rst

Signed-off-by: Mitchell Gale <[email protected]>

Added Google Java format to spotless.

Signed-off-by: Mitchell Gale <[email protected]>

Update DEVELOPER_GUIDE.rst

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #292 (b645c3e) into dev/spotless_removeUnusedImports (cffa45a) will not change coverage.
The diff coverage is n/a.

@@                         Coverage Diff                         @@
##             dev/spotless_removeUnusedImports     #292   +/-   ##
===================================================================
  Coverage                               97.39%   97.39%           
  Complexity                               4600     4600           
===================================================================
  Files                                     401      401           
  Lines                                   11381    11381           
  Branches                                  843      843           
===================================================================
  Hits                                    11084    11084           
  Misses                                    290      290           
  Partials                                    7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ecutor/streaming/MicroBatchStreamingExecution.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <ø> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <ø> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MitchellGale MitchellGale force-pushed the dev/spotless_removeUnusedImports branch from 9040729 to 26ca8d6 Compare July 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants