Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core refactor: StreamIO from common to core.common #296

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

acarbonetto
Copy link

Description

Fix compilation errors after opensearch-project/OpenSearch#8157.

Note: May need backport 2.x label.

In this PR it's only changing package name of core classes in import section

Issues Resolved

Fixes changes from opensearch-project/ml-commons#1122

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #296 (800c2b3) into integ-fix-streamioNamespace (e186cf7) will decrease coverage by 2.60%.
The diff coverage is n/a.

@@                        Coverage Diff                        @@
##             integ-fix-streamioNamespace     #296      +/-   ##
=================================================================
- Coverage                          99.98%   97.39%   -2.60%     
- Complexity                          2624     4602    +1978     
=================================================================
  Files                                205      401     +196     
  Lines                               5955    11386    +5431     
  Branches                             378      843     +465     
=================================================================
+ Hits                                5954    11089    +5135     
- Misses                                 1      290     +289     
- Partials                               0        7       +7     
Flag Coverage Δ
sql-engine 97.39% <ø> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch/sql/datasources/exceptions/ErrorMessage.java 0.00% <ø> (ø)
...model/transport/CreateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/DeleteDataSourceActionRequest.java 18.75% <ø> (ø)
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...es/model/transport/GetDataSourceActionRequest.java 27.27% <ø> (ø)
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/UpdateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/UpdateDataSourceActionResponse.java 0.00% <ø> (ø)
...ql/datasources/rest/RestDataSourceQueryAction.java 0.00% <ø> (ø)
... and 7 more

... and 179 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes - woohoo! We can ignore BWC for now.

@acarbonetto acarbonetto merged commit 372ef91 into integ-fix-streamioNamespace Jul 14, 2023
15 of 20 checks passed
acarbonetto added a commit that referenced this pull request Jul 14, 2023
* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
GumpacG pushed a commit that referenced this pull request Jul 14, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common



* Fix core refactor: StreamIO from common to core.common



---------

Signed-off-by: acarbonetto <[email protected]>
matthewryanwells pushed a commit that referenced this pull request Jul 14, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common



* Fix core refactor: StreamIO from common to core.common



---------

Signed-off-by: acarbonetto <[email protected]>
acarbonetto added a commit that referenced this pull request Jul 18, 2023
* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
MitchellGale pushed a commit that referenced this pull request Jul 20, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale pushed a commit that referenced this pull request Jul 20, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand pushed a commit that referenced this pull request Jul 27, 2023
…#296) (opensearch-project#1891)

* Fix core refactor: StreamIO from common to core.common (#296) (opensearch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit dae5a85)

* Bump Version and Fix import error

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
acarbonetto added a commit that referenced this pull request Jul 28, 2023
* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
MitchellGale pushed a commit that referenced this pull request Jul 28, 2023
…arch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
acarbonetto added a commit that referenced this pull request Aug 23, 2023
* Update documentation for _routing

Signed-off-by: acarbonetto <[email protected]>

* Proof of Concept: request routing shard through SQL partition

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common (#296)

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

* Fix core refactor: StreamIO from common to core.common

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>

* Add IT tests for multi-cluster

Signed-off-by: acarbonetto <[email protected]>

* Fix cross-cluster tests

Signed-off-by: acarbonetto <[email protected]>

* Revert query parameter 'routing'

Signed-off-by: acarbonetto <[email protected]>

* Fix unit tests with partition add

Signed-off-by: acarbonetto <[email protected]>

* clean up checkstyle and add test coverage

Signed-off-by: acarbonetto <[email protected]>

* Fix IT tests

Signed-off-by: acarbonetto <[email protected]>

* Add multi-cluster search tests to build

Signed-off-by: acarbonetto <[email protected]>

* Updates for comments

Signed-off-by: acarbonetto <[email protected]>

* Update comment

Signed-off-by: acarbonetto <[email protected]>

* Fix doctests

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants