[Spotless] Fixes license headers in core/src (PR 1) #306
Conversation
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
force-pushed
the
dev/sl_licenseHeader
branch
from
1340f6a
to
0097d53
Compare
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
We need to confirm that this file wasn't copied from another project. In that case we need to preserve the license header (or keep both).
There was a problem hiding this comment.
Looks like it was part of 254510e 254510e554156ef83365e0ea68935d4d75145330
By David Cui 2021-06-25 5:47 p.m.
There was a problem hiding this comment.
I found only one matching file on GH (name + license), but code is completely different.
https://github.com/apache/druid/blob/master/extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregator.java
https://github.com/apache/druid/blob/master/extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/StandardDeviationPostAggregator.java
I hope it is a false alarm.
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| * Copyright OpenSearch Contributors |
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| * Copyright OpenSearch Contributors |
There was a problem hiding this comment.
Checking why this has Apache 2 license.
There was a problem hiding this comment.
I guess both were by mistake: opensearch-project@8632f80
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| * Copyright OpenSearch Contributors |
Codecov Report
@@ Coverage Diff @@
## integ/sl_licenseHeader #306 +/- ##
=========================================================
Coverage 97.39% 97.39%
Complexity 4608 4608
=========================================================
Files 401 401
Lines 11408 11408
Branches 843 843
=========================================================
Hits 11111 11111
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think we need to find the previous guidance on this. For example, I recall old source file from ODFE has such license header: https://github.com/Bit-Quill/opensearch-project-sql/pull/308/files which we should not touch. If you're unclear, please disable this license header check for now. Or if you want, please spend some time to double check. |
|
opensearch-project#1893 |
Description
Fixes license headers in core/src.
Converts all header licenses to:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.