#1536: Refactor OpenSearchQueryRequest and move includes to builder #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldues to builder Signed-off-by: acarbonetto <[email protected]>
acarbonetto
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey and
GumpacG
as code owners
acarbonetto
changed the title
Codecov Report
@@ Coverage Diff @@
## integ-refactor-OpenSearchQueryRequest-includes-1536 #320 +/- ##
======================================================================================
Coverage 97.42% 97.42%
+ Complexity 4647 4646 -1
======================================================================================
Files 408 408
Lines 11526 11526
Branches 839 837 -2
======================================================================================
Hits 11229 11229
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
GumpacG
approved these changes
Aug 3, 2023
MitchellGale
approved these changes
Aug 4, 2023
acarbonetto
merged commit 41944d4
into
integ-refactor-OpenSearchQueryRequest-includes-1536
16 of 20 checks passed
acarbonetto
deleted the
dev-refactor-OpenSearchQueryRequest-includes-1536
branch
acarbonetto
added a commit
that referenced
this pull request
Aug 4, 2023
…ludes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
MitchellGale
pushed a commit
that referenced
this pull request
Aug 9, 2023
…cludes to builder (opensearch-project#1937) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 11, 2023
…cludes to builder (opensearch-project#1937) (opensearch-project#1948) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder * opensearch-project#1536: Checkstyle fixes * opensearch-project#1536: Checkstyle fixes --------- * opensearch-project#1536: Spotless Apply --------- (cherry picked from commit 7d23e0f) Signed-off-by: acarbonetto <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MitchellGale
pushed a commit
that referenced
this pull request
Aug 14, 2023
…cludes to builder (opensearch-project#1937) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor OpenSearchScrollRequest and OpenSearchQueryRequest to check for includes list in the OpenSearchRequestBuilder so that the logic to create the list is consolidated.
Issues Resolved
opensearch-project#1536
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.