[Spotless] Applying Google Code Format for integ-tests #10 #329

MitchellGale · 2023-08-04T17:42:00Z

Description

Spotless apply on integ-test (part 3 of 4 integ-test integration).

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2023-08-04T18:03:54Z

Codecov Report

Merging #329 (05c9ca0) into integ/sl_GoogleJavaFormat10 (245c4f8) will not change coverage.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##             integ/sl_GoogleJavaFormat10     #329   +/-   ##
==============================================================
  Coverage                          97.51%   97.51%           
  Complexity                          4657     4657           
==============================================================
  Files                                408      408           
  Lines                              11933    11933           
  Branches                             829      829           
==============================================================
  Hits                               11637    11637           
  Misses                               289      289           
  Partials                               7        7

Flag	Coverage Δ
sql-engine	`97.51% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Yury-Fridlyand · 2023-08-05T00:08:20Z

integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java

-        + "Other Databases  :\n" + otherDbConnectionInfoToString() + '\n'
-        + "Test data set(s) :\n" + testDataSetsToString() + '\n'
-        + "Test query set   : " + testQuerySet + '\n'
+        + "Tested Database  : "


...there are worse things

integ-test/src/test/java/org/opensearch/sql/correctness/testset/TestDataSet.java

Signed-off-by: Mitchell Gale <[email protected]>

acarbonetto · 2023-08-14T22:45:52Z

integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java

-        + "Other Databases  :\n" + otherDbConnectionInfoToString() + '\n'
-        + "Test data set(s) :\n" + testDataSetsToString() + '\n'
-        + "Test query set   : " + testQuerySet + '\n'
+        + "Tested Database  : "


...there are worse things

acarbonetto · 2023-08-14T22:48:19Z

integ-test/src/test/java/org/opensearch/sql/correctness/tests/TestReportTest.java

-            "}"
-    );
+    JSONObject expected =
+        new JSONObject(


I do not like how it combined the strings here

Agreed. I can fix.

acarbonetto · 2023-08-14T22:59:08Z

integ-test/src/test/java/org/opensearch/sql/legacy/TestUtils.java

-   * https://github.com/elastic/elasticsearch/pull/49959
-   * Deprecate creation of dot-prefixed index names except for hidden and system indices.
-   * Create hidden index by REST client.
+   * https://github.com/elastic/elasticsearch/pull/49959 Deprecate creation of dot-prefixed index


Suggested change

* https://github.com/elastic/elasticsearch/pull/49959 Deprecate creation of dot-prefixed index

* https://github.com/elastic/elasticsearch/pull/49959 <br> Deprecate creation of dot-prefixed index

acarbonetto · 2023-08-14T23:00:17Z

integ-test/src/test/java/org/opensearch/sql/ppl/SystemFunctionIT.java

+    JSONObject response =
+        executeQuery(
+            String.format(
+                "source=%s | eval `str` = typeof('pewpew'), `double` = typeof(1.0),`int` ="


is there a way to avoid reformatting the strings here?

Yes, fixed.

acarbonetto · 2023-08-14T23:01:35Z

integ-test/src/test/java/org/opensearch/sql/util/TestUtils.java

-   * https://github.com/elastic/elasticsearch/pull/49959
-   * Deprecate creation of dot-prefixed index names except for hidden and system indices.
-   * Create hidden index by REST client.
+   * https://github.com/elastic/elasticsearch/pull/49959 Deprecate creation of dot-prefixed index


Suggested change

* https://github.com/elastic/elasticsearch/pull/49959 Deprecate creation of dot-prefixed index

* https://github.com/elastic/elasticsearch/pull/49959 <br> Deprecate creation of dot-prefixed index

Addressed, thanks.

Signed-off-by: Mitchell Gale <[email protected]>

Yury-Fridlyand

Thanks for fixing multiline strings!

Signed-off-by: Mitchell Gale <[email protected]>

…h-project#1967) * [Spotless] Applying Google Code Format for integ-tests #10 (#329) * Add spotless apply 33 files. Signed-off-by: Mitchell Gale <[email protected]> * Addressed PR comments. Signed-off-by: Mitchell Gale <[email protected]> * Address PR comments. Signed-off-by: Mitchell Gale <[email protected]> * fixing integ test failure. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> * Update integ-test/src/test/java/org/opensearch/sql/correctness/tests/TestConfigTest.java Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>

MitchellGale requested review from MaxKsyunz, Yury-Fridlyand, forestmvey, acarbonetto and GumpacG as code owners August 4, 2023 17:42

MitchellGale assigned GumpacG and acarbonetto Aug 4, 2023

Yury-Fridlyand approved these changes Aug 5, 2023

View reviewed changes

Yury-Fridlyand approved these changes Aug 8, 2023

View reviewed changes

MitchellGale added 2 commits August 14, 2023 15:36

Add spotless apply 33 files.

6a13a06

Signed-off-by: Mitchell Gale <[email protected]>

Addressed PR comments.

4ee9597

Signed-off-by: Mitchell Gale <[email protected]>

MitchellGale force-pushed the dev/sl_GoogleJavaFormat10 branch from fd825ab to 4ee9597 Compare August 14, 2023 22:36

acarbonetto approved these changes Aug 14, 2023

View reviewed changes

Address PR comments.

a154b9d

Signed-off-by: Mitchell Gale <[email protected]>

Yury-Fridlyand approved these changes Aug 15, 2023

View reviewed changes

fixing integ test failure.

05c9ca0

Signed-off-by: Mitchell Gale <[email protected]>

Yury-Fridlyand approved these changes Aug 15, 2023

View reviewed changes

MitchellGale merged commit e9ea27e into integ/sl_GoogleJavaFormat10 Aug 15, 2023
14 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Spotless] Applying Google Code Format for integ-tests #10 #329

[Spotless] Applying Google Code Format for integ-tests #10 #329

MitchellGale commented Aug 4, 2023

codecov bot commented Aug 4, 2023 •

edited

Loading

Yury-Fridlyand Aug 5, 2023

acarbonetto Aug 14, 2023

acarbonetto Aug 14, 2023

acarbonetto Aug 14, 2023

MitchellGale Aug 14, 2023

MitchellGale Aug 14, 2023

acarbonetto Aug 14, 2023

MitchellGale Aug 14, 2023

acarbonetto Aug 14, 2023

MitchellGale Aug 14, 2023

acarbonetto Aug 14, 2023

MitchellGale Aug 14, 2023

Yury-Fridlyand left a comment

	* https://github.com/elastic/elasticsearch/pull/49959 Deprecate creation of dot-prefixed index
	* https://github.com/elastic/elasticsearch/pull/49959 <br> Deprecate creation of dot-prefixed index

[Spotless] Applying Google Code Format for integ-tests #10 #329

[Spotless] Applying Google Code Format for integ-tests #10 #329

Conversation

MitchellGale commented Aug 4, 2023

Description

Issues Resolved

Check List

codecov bot commented Aug 4, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yury-Fridlyand left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 4, 2023 •

edited

Loading