Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for ppl files #12 #339

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

MitchellGale
Copy link

Description

Applies spotless for ppl directory in project. Sets checkstyle to not fail on failure for ppl directory.

Issues Resolved

opensearch-project#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #339 (e68a194) into integ/sl_GoogleJavaFormat12 (5381a6f) will increase coverage by 1.06%.
The diff coverage is 100.00%.

❗ Current head e68a194 differs from pull request most recent head e6a35a5. Consider uploading reports for the commit e6a35a5 to get more accurate results

@@                        Coverage Diff                        @@
##             integ/sl_GoogleJavaFormat12     #339      +/-   ##
=================================================================
+ Coverage                          97.51%   98.58%   +1.06%     
+ Complexity                          4656     4176     -480     
=================================================================
  Files                                408      335      -73     
  Lines                              11930    10296    -1634     
  Branches                             829      695     -134     
=================================================================
- Hits                               11634    10150    -1484     
+ Misses                               289      141     -148     
+ Partials                               7        5       -2     
Flag Coverage Δ
sql-engine 98.58% <100.00%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...opensearch/sql/ppl/parser/AstStatementBuilder.java 83.33% <ø> (ø)
...opensearch/sql/ppl/utils/UnresolvedPlanHelper.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/ppl/PPLService.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/ppl/antlr/PPLSyntaxParser.java 100.00% <100.00%> (ø)
...org/opensearch/sql/ppl/domain/PPLQueryRequest.java 100.00% <100.00%> (ø)
...rg/opensearch/sql/ppl/domain/PPLQueryResponse.java 100.00% <100.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <100.00%> (ø)
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/ppl/utils/ArgumentFactory.java 100.00% <100.00%> (ø)
...ensearch/sql/ppl/utils/PPLQueryDataAnonymizer.java 100.00% <100.00%> (ø)

... and 75 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Mitchell Gale <[email protected]>
@MitchellGale MitchellGale merged commit ad3cfa5 into integ/sl_GoogleJavaFormat12 Aug 16, 2023
17 of 18 checks passed
MitchellGale added a commit that referenced this pull request Aug 16, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
MitchellGale added a commit that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
MitchellGale added a commit that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
MitchellGale added a commit that referenced this pull request Aug 22, 2023
…project#1972)

* Spotless apply on PPL (#339)

Signed-off-by: Mitchell Gale <[email protected]>

* Update ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java

Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant