Skip to content

Conversation

@benma
Copy link
Collaborator

@benma benma commented Jun 5, 2020

No description provided.

benma added 2 commits June 5, 2020 13:28
With the previous 1.11 version, this line failed:

RUN go get -v -u
github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc

(possibly that cmd became incompatible somehow?).
We went to nightly to be able to use async on no_std. With tomorrow's release of stable 1.44.0, this is available in stable, so no reason for us to be reckless 😇

https://www.reddit.com/r/rust/comments/fn6zzq/async_functions_for_no_std_now_available_on/

https://github.com/rust-lang/rust/blob/master/RELEASES.md
With the symbols present, this happened:

```
/usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memcpy' because it is named in a relocation
/usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memmove' because it is named in a relocation
/usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memset' because it is named in a relocation
```

Seems like in the updated Rust toolchain, the symbols are correctly
referenced and no workaround is needed.
@benma benma requested a review from x1ddos June 5, 2020 12:00
After updating Go and going to Rust toolchain 1.44.0.
@benma benma closed this Jun 5, 2020
@benma
Copy link
Collaborator Author

benma commented Jun 5, 2020

CI not working ,was hoping reopening the PR will help - #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant