Merged
Conversation
With the previous 1.11 version, this line failed: RUN go get -v -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc (possibly that cmd became incompatible somehow?).
We went to nightly to be able to use async on no_std. With tomorrow's release of stable 1.44.0, this is available in stable, so no reason for us to be reckless 😇 https://www.reddit.com/r/rust/comments/fn6zzq/async_functions_for_no_std_now_available_on/ https://github.com/rust-lang/rust/blob/master/RELEASES.md
Closed
Collaborator
Author
|
Uuh... |
Contributor
|
Ha! Abuse!? What abuse? 🙈 Maybe we should really switch from travis to github workflows: https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow. I'll try to play with it and see if it can work for us. |
x1ddos
approved these changes
Jun 5, 2020
Contributor
x1ddos
left a comment
x1ddos
left a comment
There was a problem hiding this comment.
LGTM. I don't have a device to flash and boot it at the moment but it all seems to build fine:
dockeruser@ce18181884d8$ rustc --version
rustc 1.44.0 (49cae5576 2020-06-01)
dockeruser@ce18181884d8$ go version
go version go1.14.4 linux/amd64
$ make -j firmware
...
Generating binary firmware.bin
text data bss dec hex filename
414652 18808 208720 642180 9cc84 firmware.elf
$ make -j bootloader
...
Generating binary bootloader.bin
text data bss dec hex filename
42672 4368 190112 237152 39e60 bootloader.elf
Collaborator
Author
|
Ran CI locally, got this in @NickeZ any idea how to debug? 😇 Edit: added the offending symbols in the same place in the @x1ddos pls re-check- |
With the symbols present, this happened: ``` /usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memcpy' because it is named in a relocation /usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memmove' because it is named in a relocation /usr/local/bin/arm-none-eabi-objcopy: not stripping symbol `memset' because it is named in a relocation ``` Seems like in the updated Rust toolchain, the symbols are correctly referenced and no workaround is needed. In return, some other symbols now seem to clash, but only in device-tests.
After updating Go and going to Rust toolchain 1.44.0.
in bitbox02-rust-c, we use Enabling lang-items is unstable. The workaround is to use RUSTC_BOOTSTRAP=1 to enable this (while still being on a stable toolchain), which was applied to the unit tests and firmware, but not the docs. I assume the docs target was added after we temporarily went to the nightly toolchain.
Contributor
|
Oh, I forgot to run the tests! Sorry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.