Integrated pull request ultimatecourses#32

BitLoopTech · May 8, 2018 · 8ecabf7 · 8ecabf7
1 parent a96cd2a
commit 8ecabf7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,11 +1,11 @@
 {
-  "name": "@ultimate/ngxerrors",
-  "version": "0.0.0",
+  "name": "ngx-errors-complete",
+  "version": "4.1.1",
   "description": "A declarative validation module for reactive forms",
   "author": "Ultimate Angular",
   "license": "MIT",
   "repository": {
-    "url": "https://github.com/UltimateAngular/ngxerrors.git",
+    "url": "https://github.com/BitLoopTech/ngx-errors.git",
     "type": "git"
   },
   "scripts": {

diff --git a/src/ngxerror.directive.ts b/src/ngxerror.directive.ts
@@ -70,6 +70,7 @@ export class NgxErrorDirective implements OnInit, OnDestroy, DoCheck {
   }
 
   ngOnDestroy() {
+    this._states.complete();
     this.subscription.unsubscribe();
   }
 

diff --git a/src/ngxerrors.directive.ts b/src/ngxerrors.directive.ts
@@ -16,7 +16,7 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
   @Input('ngxErrors')
   controlName: string;
 
-  subject = new BehaviorSubject<ErrorDetails>(null);
+  subject: BehaviorSubject<ErrorDetails>;
 
   control: AbstractControl;
 
@@ -71,6 +71,10 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
     }
   }
 
+  ngOnInit() {
+    this.subject = new BehaviorSubject<ErrorDetails>(null);
+  }
+
   ngOnChanges() {
     this.control = this.form.control.get(this.controlName);
   }
@@ -83,7 +87,7 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
   }
 
   ngOnDestroy() {
-    this.subject.unsubscribe();
+    this.subject.complete();
   }
 
 }
-Original file line number
+Diff line change
@@ Expand Up @@
       }
       ngOnDestroy() {
+        this._states.complete();
         this.subscription.unsubscribe();
       }
@@ Expand Down @@