Modify lookup poly evaluator for the convenience of verification in plonk example #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: PayneJoe <[email protected]>
weikengchen
reviewed
Aug 23, 2024
weikengchen
reviewed
Aug 23, 2024
weikengchen
reviewed
Aug 23, 2024
weikengchen
reviewed
Aug 23, 2024
weikengchen
added a commit
that referenced
this pull request
Sep 13, 2024
change mix_nonce to be consistent update sha256 channel impl: Modify lookup poly evaluator for the convenience of verification in plonk example (#15) * Cumulative changes to stwo Co-authored-by: PayneJoe <[email protected]> * temp change: flip the sign on mul in plonk; this temp change may be discarded * allow small blowup * add tiny blowup * parallel sha256 * change publicity of sampled_values_to_mask * add evaluation hint on PointEvaluator * three constraints (batched) * fix publicity of alpha_powers in lookup elements * remove bws sha256 files * Update sha256.rs * Update sha256.rs * Update mod.rs * Update mod.rs * Update mod.rs * Update crates/prover/src/constraint_framework/point.rs * Apply suggestions from code review --------- Co-authored-by: Weikeng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the convenience of logup verification in plonk example, this PR mainly add two small modifications:
PointEvaluatoralpha_powers