fix: correct mempool test formatting failure - #4
Open
tolga-tom-nook wants to merge 1 commit into
Open
Conversation
Fix a `testing.T.Fatal` call that includes a `%d` formatting directive and an argument.\n\n`go test ./mempool` fails vet/build validation with:\n\n (*testing.common).Fatal call has possible Printf formatting directive %d\n\nSwitching to `Fatalf` matches the call shape and keeps the intended assertion message.
This was referenced May 24, 2026
|
Maintainers: this PR looks like a clean Bitgesell btcsuite#81 candidate because it fixes a real Acceptance checks I would use before merge:
From the public diff, this is the sort of narrow maintainer-friendly patch that should be easy to approve if the branch still reproduces the vet failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Fatalcall with a%dformatting directive tot.FatalfRoot cause / acceptance proof
On the upstream
BitgesellOfficial/bgldmasterbranch,go test ./mempoolcurrently fails before tests run because vet rejects the formatting directive passed tot.Fatal:This PR uses
t.Fatalf, which is the intended testing helper when the message has printf-style formatting plus arguments.Validation
master:go test ./mempoolfails with the vet error abovego test ./mempoolBounty note
Submitting as a focused test/build reliability improvement for the Bitgesell bounty/improvement program, especially BitgesellOfficial/bitgesell#81. If approved for payout, USDT/EVM-compatible address:
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428.Assisted by Hermes Agent.