Skip to content

chore: align bip39 package metadata - #3

Open
manuelsampedro1 wants to merge 1 commit into
BitgesellOfficial:mainfrom
manuelsampedro1:codex/bip39-package-metadata
Open

chore: align bip39 package metadata#3
manuelsampedro1 wants to merge 1 commit into
BitgesellOfficial:mainfrom
manuelsampedro1:codex/bip39-package-metadata

Conversation

@manuelsampedro1

Copy link
Copy Markdown

The package metadata still carried upstream/stale values in a few places. In particular, the committed package-lock root identified the project as bip39 version 3.1.0, while package.json publishes this fork as bitgesell-bip39 version 0.1.0. The package repository URL also pointed at the older personal fork.

Changes:

  • align package-lock root name/version with package.json
  • update package.json repository URL to the BitgesellOfficial repository
  • adjust the package description from Bitcoin BIP39 to Bitgesell BIP39
  • remove a stray blank line in package.json metadata

Validation:

  • parsed package.json and package-lock.json with Node
  • checked stale package metadata references with rg
  • git diff --check

Note: I could not run npm scripts locally because npm is not available in this environment.

Bounty context: BitgesellOfficial/bitgesell#39

@MyTH-zyxeon

Copy link
Copy Markdown

Maintainer review note for the #81/#39 improvement queue:

I checked head 0b9e369: this is a narrow package metadata alignment patch. The decoded package.json now publishes bitgesell-bip39 version 0.1.0, the package-lock.json root matches the same name/version, and the old personal repository URL plus the stale Bitcoin BIP39 description are gone.

Acceptance checks:

  • Keep package.json and the package-lock root in lockstep for name and version so npm consumers do not see split package identity.
  • Confirm the official repository URL casing is the convention maintainers want before publishing/tagging.
  • Run the JSON parse / git diff --check validations from the PR body before merge.
  • Because npm scripts were not run locally, keep this scoped as metadata-only unless maintainers can run a package smoke test in their environment.

No wallet/key/node/live-chain scope; this is docs/package metadata hygiene only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants