fix: use configured SDK logger - #1
Open
DYSfu wants to merge 1 commit into
Open
Conversation
|
Review assist for maintainers: This looks like a useful SDK correctness/testability fix: the Address, Blockchain, Mempool, and Transactions wrappers now use Suggested merge checks:
I do not see wallet/key, signing, broadcast, live RPC, or live-chain behavior changes in this patch as written; the acceptance criterion is that configured logger callbacks are actually invoked on request failures and the whole SDK test suite is no longer accidentally focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation:
npm ci --legacy-peer-depsnpx jest src/__tests__/logger.test.ts --runInBand-> 4 tests passednpm run build:mainnpm test -- --runInBand-> 26 tests passedgit diff --checkRelated: