Skip to content

fix: fetch aggregate mempool state endpoint #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolga-tom-nook wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fetch aggregate mempool state endpoint #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/__tests__/mempool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ describe('Mempool tests', () => {
})

it('should fetch mempool state', async () => {
const orderBy = 'asc'
const mempoolState = bitgesellBlockchainSDK.mempool.getMempoolState(1, orderBy)
expect(mempoolState).toBeDefined()
const mempoolState = await bitgesellBlockchainSDK.mempool.getMempoolState()
expect(mempoolState).toHaveProperty('inputs')
expect(mempoolState).toHaveProperty('outputs')
expect(mempoolState).toHaveProperty('transactions')
})

it('should get invalid Transactions in the mempool', async () => {
Expand Down
12 changes: 4 additions & 8 deletions src/classes/Mempool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,10 @@ export class Mempool {
}

/**
* @param limit limit per page
* @param order order results by des, asc etc
* @param fromTimestamp timestamp limit to fetch up th current timestamp
* @param page number of page results to fetch default = 1
* getMempoolState fetches mempool state
*/
public async getMempoolState(limit?: number, order?: string, fromTimestamp?: number, page = 1): Promise<MempoolState> {
const url = `${this.apiV1URL}/mempool/transactions?page=${page}&limit=${limit}&order=${order}&from_timestamp=${fromTimestamp}`
* getMempoolState fetches aggregate mempool state.
*/
public async getMempoolState(): Promise<MempoolState> {
const url = `${this.apiV1URL}/mempool/state`
const data = await this._get(url)
return data as MempoolState
}
Expand Down