Skip to content

test: align constructor port expectations with Bitgesell #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logical34 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: align constructor port expectations with Bitgesell #10

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c50b2
test: align constructor port expectations with Bitgesell
logical34 Jun 5, 2026
de11cea
test: document unsupported regtest network
logical34 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions test/client_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,17 @@ describe('Client', () => {
});

it('should have default port set to `mainnet`\'s one', () => {
should(new Client().port).equal(8332);
should(new Client().port).equal(8454);
});

it('should set default to port `8332` if network is `mainnet`', () => {
should(new Client({ network: 'mainnet' }).port).equal(8332);
it('should set default to port `8454` if network is `mainnet`', () => {
should(new Client({ network: 'mainnet' }).port).equal(8454);
});

it('should set default to port `18332` if network is `testnet`', () => {
should(new Client({ network: 'testnet' }).port).equal(18332);
});

it('should set default to port `18332` if network is `regtest`', () => {
should(new Client({ network: 'regtest' }).port).equal(18332);
});

it('should not have ssl enabled by default', () => {
should(new Client().ssl.enabled).equal(false);
should(new Client().ssl.strict).equal(false);
Comment on lines 68 to 78
Expand Down