fix: restore clean npm install - #7
Open
ManuelSalcedo2770 wants to merge 1 commit into
Open
Conversation
|
Maintainer review-assist for #39:
No secrets, dependency install, build/test run, local checkout mutation, wallet/key action, live node/RPC call, live-chain action, payment action, or claim submission was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-plugin-functionalto a release compatible with the repo's ESLint 8 dev dependency.@types/nodeto a TypeScript 4.9-compatible release so the TypeScript build does not resolve newer Node declarations requiring newer TS libs.doc:json.Why
A clean checkout currently cannot run
npm cibecause there is no root lockfile, andnpm installfails on the ESLint peer dependency mismatch. After generating a lockfile, the build also resolves Node types that are too new for the repo's TypeScript 4.9 setup. This PR keeps the change scoped to dependency/tooling reproducibility.Verification
npm cinpm run buildnpm run doc:jsongit diff --checkNote:
npm test -- --runInBandstill requires local bridge configuration values in a clean checkout, so I did not list it as passing verification.Submitted for the Bitgesell PR bounty hunt: BitgesellOfficial/bitgesell#39. Payout details can be provided after maintainer review/approval.