Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/organise src folder #46

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor/organise src folder #46

wants to merge 10 commits into from

Conversation

aagbotemi
Copy link

I organised the src folder with proper modules and lib.rs file

goebb
goebb reviewed Sep 6, 2024
View reviewed changes
Copy link

@goebb goebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the select_coin function is duplicated in lib.rs and selectcoin.rs?

@aagbotemi aagbotemi requested a review from goebb September 7, 2024 20:17
@aagbotemi
Copy link
Author

please review again

@aagbotemi aagbotemi mentioned this pull request Sep 7, 2024
Open
@NeoZ666
Copy link
Contributor

NeoZ666 commented Sep 30, 2024

Kindly pull and just add the bnb as well

@aagbotemi
Copy link
Author

add the bnb

I've added the bnb

jkciw
jkciw reviewed Oct 4, 2024
View reviewed changes
src/selectcoin.rs Outdated
@@ -0,0 +1,135 @@
use crate::algorithms::bnb::select_coin_bnb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BNB can be added into the existing use crate statement.

Copy link
Author

@aagbotemi aagbotemi Oct 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check again @jkciw

@delcin-raj
Copy link
Collaborator

Looks good to me, think we can merge during the sync call today

@aagbotemi aagbotemi mentioned this pull request Oct 7, 2024
Open
@aagbotemi
Copy link
Author

pr has been updated for removal of is segwit field @delcin-raj

@delcin-raj
Copy link
Collaborator

There are clippy errors.
Ignore unused variable in srd.rs.

But remove the unused variables in util.rs

@aagbotemi
Copy link
Author

they are fixed

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.00000% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@eaad338). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/types.rs 7.40% 25 Missing ⚠️
src/algorithms/knapsack.rs 97.98% 7 Missing ⚠️
src/algorithms/lowestlarger.rs 93.67% 5 Missing ⚠️
src/algorithms/bnb.rs 97.52% 3 Missing ⚠️
src/utils.rs 95.65% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage        ?   94.93%           
=======================================
  Files           ?        9           
  Lines           ?      829           
  Branches        ?        0           
=======================================
  Hits            ?      787           
  Misses          ?       42           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

delcin-raj
delcin-raj approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@delcin-raj delcin-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delcin-raj
Copy link
Collaborator

Your commits need to be signed.

@NeoZ666
Copy link
Contributor

NeoZ666 commented Oct 29, 2024

LGTM too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkciw jkciw jkciw left review comments

@delcin-raj delcin-raj delcin-raj approved these changes

@goebb goebb Awaiting requested review from goebb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aagbotemi @NeoZ666 @delcin-raj @codecov-commenter @jkciw @goebb