Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use monorepo and workspaces #34

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Use monorepo and workspaces #34

merged 2 commits into from
Feb 26, 2024

Conversation

theanmolsharma
Copy link
Collaborator

No description provided.

emjshrx
emjshrx approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@emjshrx emjshrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the install, test, and type check scripts and works fine. Added minor comments that arent blockers. ack

.github/workflows/lint.yml Outdated Show resolved Hide resolved
packages/esplora/src/esplora.ts Show resolved Hide resolved
packages/wallet/src/wallet.ts Show resolved Hide resolved
@emjshrx
Copy link
Contributor

emjshrx commented Feb 26, 2024

Also there seems to be changes to package-lock.json thats not pushed

@theanmolsharma
Copy link
Collaborator Author

Addressed comments and updated package-lock.json.

@theanmolsharma theanmolsharma merged commit a37c02c into main Feb 26, 2024
2 checks passed
@theanmolsharma theanmolsharma deleted the workspaces branch February 26, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emjshrx emjshrx emjshrx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theanmolsharma @emjshrx