feat: add parseSilentBlock #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitika
force-pushed
the
feat/parse-silent-block
branch
from
8469e74
to
a250d69
Compare
theanmolsharma
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Nice work!! The parseSilentBlock function looks solid 🚀
Suggested a few nits and test improvements.
Things to look out for:
- Ensure you don't create extra commits while addressing the comments.
- Before we merge, you must sign your commits with a publically verifiable key. [ref]
- CI is failing because of formatting issues in your code. Make sure you set up
eslintandprettiercorrectly in your local IDE. We also have a pre-commit hook configured to run format fixing and linting checks. You should start using it.
You need to runnpx husky installand the next time you commit your changes, a pre-commit check will run
chaitika
force-pushed
the
feat/parse-silent-block
branch
from
a24ea21
to
7e82da8
Compare
chaitika
force-pushed
the
feat/parse-silent-block
branch
from
4cdf7e9
to
6405983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.