Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback for CTCarrier deprecation #48

Closed
wants to merge 1 commit into from
Closed

Add fallback for CTCarrier deprecation #48

wants to merge 1 commit into from

Conversation

mic-ioki
Copy link
Contributor

@mic-ioki mic-ioki commented May 8, 2023

Changes

Use Locale region identifier for iOS 16.4 later and CoreTelephony for earlier.

Issues

How To Test

  • Run CountryPickerViewController.defaultCountry() on:
    • Device with iOS > 16.4, return value should be equal to device setting's region.
    • Device with iOS < 16.4, return value should be equal to device's sim country.

Blackjacx
Blackjacx requested changes May 9, 2023
View reviewed changes
Copy link
Owner

@Blackjacx Blackjacx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey 👋

changes look good! Can you add a changelog entry too please? This works by manually adding the PR title to changelog.md.

@mic-ioki mic-ioki closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackjacx Blackjacx Blackjacx requested changes

Assignees

@mic-ioki mic-ioki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTCarrier Deprecation
2 participants
@mic-ioki @Blackjacx