Add sequence number handling to streaming events in OpenAI endpoint #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwohlfahrt
commented
Sep 4, 2025
dwohlfahrt
commented
- Introduced a SequenceNumber class to manage and increment sequence numbers for streaming events.
- Updated various event responses in the openai_endpoint to include the sequence number, ensuring compliance with the OpenAI pipeline.
- Enhanced event data consistency by incorporating sequence numbers in response events such as response.created, response.in_progress, and others.
- Introduced a SequenceNumber class to manage and increment sequence numbers for streaming events. - Updated various event responses in the openai_endpoint to include the sequence number, ensuring compliance with the OpenAI pipeline. - Enhanced event data consistency by incorporating sequence numbers in response events such as response.created, response.in_progress, and others.
dwohlfahrt
commented
Sep 4, 2025
| "input_tokens": usage_stats["input_tokens"], | ||
| "output_tokens": usage_stats["output_tokens"], | ||
| "total_tokens": usage_stats["input_tokens"] | ||
| "usage": OpenAIUsage( |
There was a problem hiding this comment.
This fixes this Pydantic warning:
/Users/dwohlfahrt/workspace/github/dwohlfahrt/mlx-testbed/.venv/lib/python3.13/site-packages/pydantic/main.py:519: UserWarning: Pydantic serializer warnings:
PydanticSerializationUnexpectedValue(Expected `OpenAIUsage` - serialized value may not be as expected [input_value={'input_tokens': 33, 'out... 13, 'total_tokens': 46}, input_type=dict])
return self.__pydantic_serializer__.to_json(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.