Remove group node #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Aug 9, 2024
Comment on lines
+120
to
+122
| self.include_features = False | ||
| self.inflate_aabb = 0.0 | ||
| self.inflate_obb = 0.0 |
There was a problem hiding this comment.
these are missing in docstring
chenkasirer
reviewed
Aug 9, 2024
| If ``True``, include the features in the computed geometry. | ||
| If ``False``, return only the base geometry. | ||
| Implementations of this method should transform the geometry to world coordinates, | ||
| using `self.worltransformation`. |
There was a problem hiding this comment.
Suggested change
| using `self.worltransformation`. | |
| using `self.worldtransformation`. |
chenkasirer
reviewed
Aug 9, 2024
| # ========================================================================== | ||
| # Computed attributes | ||
| # ========================================================================== | ||
|
|
||
| # it might be easier to just always compute these |
chenkasirer
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the group node and makes all nodes simply element nodes.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.