Show 'Title is required' when creating a task without a title #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britannio
commented
Nov 26, 2025
|
|
||
| useKeySubmitTaskAlt(handleSubmitCreateOnly, { | ||
| enabled: modal.visible && canSubmitAlt && !showDiscardWarning, | ||
| enabled: shortcutsEnabled, |
Collaborator
Author
There was a problem hiding this comment.
The shortcut to create a task without starting it should work even if the form is in an invalid state (missing title).
britannio
commented
Nov 26, 2025
| disabled={isSubmitting} | ||
| autoFocus | ||
| /> | ||
| {!field.state.meta.isValid && ( |
Collaborator
Author
There was a problem hiding this comment.
Here we show the 'Title is required' warning if validation fails during submission.
britannio
commented
Nov 26, 2025
| <Button onClick={form.handleSubmit} disabled={!canSubmit}> | ||
| {buttonText} | ||
| </Button> | ||
| <Button onClick={form.handleSubmit}>{buttonText}</Button> |
Collaborator
Author
There was a problem hiding this comment.
the button is always enabled now, rather than only when the form is valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title text size has also been increased.