Revert building shuffle.c with SSE2/AVX2 compilation flags
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkitti, does this solves your issue? |
t20100
commented
Jul 21, 2023
| #if defined(SHUFFLE_USE_AVX2) || defined(SHUFFLE_USE_SSE2) /* Intel/i686 */ | ||
| implementations supported by the host processor for Intel/i686 | ||
| */ | ||
| #if (defined(__x86_64__) || defined(_M_X64) || defined(__i386__) || defined(_M_IX86)) \ |
There was a problem hiding this comment.
From looking a bit around, that should detect x86 arch with main compilers.
I'd take any better way
|
I'm tracking this pull request, and I will report back. I am a bit busy at the moment, but I may have some time over the weekend while traveling. |
|
I am away from the computer where I had this issue. I can check this evening. Can you check in with me in 24 hours? |
|
main branch: 76% tests passed, 400 tests failed out of 1643
Please merge. Thank you. |
|
Could we generate a new release with these changes? |
|
Thanks for the reminder @mkitti . Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing #371. It:
shuffle.cwhich is responsible for issue Illegal Instruction vinserti128 in set_host_implementation #371.__SSE2__(resp.__AVX2__) is not available, so that the symbols are always defined (useful for multiple architecture compilation like for macos universal build (x86 + arm).SHUFFLE_AVX2_ENABLEDorSHUFFLE_SSE2_ENABLEDdefined) for using ablosc_get_cpu_featuresimplementation that detects hardware.