Fixing bytedelta #532
Merged
Fixing bytedelta #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, we see build issues in cibuildwheel with this when
it is not quoted. Probably when defines as an empty string it throws:
```
...
-- Using ZSTD internal sources.
"STREQUAL" "arm64"
-- Configuring incomplete, errors occurred!
Unknown arguments specified
```
See #526. Designated initializers are in C99 but only in C++20, too.
I see downstream linkage issues with externally built, static zlib library on Windows. This tries to fix it. Docs: - https://cmake.org/cmake/help/v3.27/module/FindZLIB.html Generally, we should use `ZLIB::ZLIB` as the target to link instead of decluttering these result variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of #531 , where a new filter ID has been introduced for the fixed version of bytedelta (see #524 for details). However, it looks like there are still issues (probably with SIMD code). Maybe @froody or @aras-p can shed more light here?