Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass -m flags when compiling shuffle.c #622

Merged
merged 8 commits into from
Jul 4, 2024

Commits on Jun 25, 2024

  1. Do not pass -m flags when compiling shuffle.c

    Do not pass `-msse2`, `-mavx2`, etc. flags to the compiler when
    compiling `shuffle.c`.  From what I can see, the file itself does not
    use any of these intrinsics, and they are only used by functions
    declared in `bitshuffle-*.c` and `shuffle-*.c` (where the respective
    flags are still passed).  This prevents the compiler from incidentally
    optimizing the code called independenlty of the runtime CPU check to
    these instruction sets, effectively causing `SIGILL` on other CPUs.
    
    I have verified that this fixes the issue on `-march=znver2`, but also
    does not cause any issues on `-march=x86-64` and `-march=i686`.
    
    Fixes Blosc#621
    mgorny committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    73b1225 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    b15c187 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06b5da3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4817a41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9afb7b9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a7fdcef View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a0c0b88 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #1 from t20100/shuffle-flags

    Add runtime checks for use of SIMD implementations and stubs functions if not available.
    mgorny authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ce42731 View commit details
    Browse the repository at this point in the history