lewd summon quirk #1251
Open
lewd summon quirk #1251
+170
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kush1Push1
reviewed
Sep 3, 2024
Kush1Push1
reviewed
Sep 3, 2024
| /obj/effect/summon_rune/attack_hand(mob/living/carbon/M) | ||
| var/list/applicants = list() | ||
| var/static/list/applicants_result = list() | ||
| for(var/mob/living/carbon/human/H in GLOB.carbon_list) |
There was a problem hiding this comment.
- Почему список карбонов?
- Сделай так, чтобы квирк самона добавлялся в отдельный global. Тебе не нужно просматривать список из 100+ сущностей с учётом трупов, у каждого устраивая if
Kush1Push1
reviewed
Sep 3, 2024
| return | ||
| else | ||
|
|
||
| var/applicant_choice = tgui_alert(target, "You have been summoned! Do you want to answer?", "Do you want to answer?", list("Yes", "No")) |
There was a problem hiding this comment.
Алёрт это плохая идея. Лучше сделать оповещение в чат с кнопкой. Могу подсказать где достать код для имплементации лёгкой на примере.
Kush1Push1
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Merge Checklist