Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: xtensor stores #1001

Conversation

mmarineBlueQuartz
Copy link
Collaborator

Add xtensor-backed data stores to SIMPL NX.

Added data stores for:

  • StringArray / strings
  • NeighborList / lists

Updated DataArray's AbstractDataStore to use xt::xarray

Add vcpkg dependencies for xtensor.
Include xtensor libraries.

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

  • 1 Unit test to test output from the filter against known exemplar set of data
  • 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

  • No commented out code (rare exceptions to this is allowed..)
  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added example pipelines that use the filter
  • Classes and methods are properly documented

@imikejackson
Copy link
Contributor

@mmarineBlueQuartz Are we adding back in support for GHCFileSystem? All of our compilers that we support no longer need that package. Or is that a dependency for XTensor?

@mmarineBlueQuartz
Copy link
Collaborator Author

@mmarineBlueQuartz Are we adding back in support for GHCFileSystem? All of our compilers that we support no longer need that package. Or is that a dependency for XTensor?

XTensor. One of the includes was causing errors when it wasn't found.

@imikejackson imikejackson force-pushed the test/xtensor_store branch 2 times, most recently from d9d63da to ec8ae03 Compare June 27, 2024 00:33
@imikejackson imikejackson force-pushed the test/xtensor_store branch 3 times, most recently from cf38d81 to ca5f475 Compare July 9, 2024 14:36
mmarineBlueQuartz and others added 6 commits July 9, 2024 10:41
* ResampleImageGeom: Wrong AttributeMatrix dimensions, zeroed out array values.
* ApplyTransformationToGeometry: DataArray filled with 0.
* InterpolatePointCloudToRegularGrid
* xtensor
* xtensor-io
* Enabled disabled unit tests
* Remove added debug print statements
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson
Copy link
Contributor

Closed because there is a new branch to work from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants