[WIP] BUG: Rework API for DataMap and DeepCopy in DataObject. #864
+43
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
added
bug
imikejackson
requested review from
mmarineBlueQuartz,
JDuffeyBQ and
nyoungbq
nyoungbq
reviewed
Feb 20, 2024
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
1574138
to
87026c2
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
87026c2
to
6656d8c
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
2 times, most recently
from
5f6a520
to
943f344
Compare
imikejackson
force-pushed
the
develop
branch
2 times, most recently
from
67a7875
to
12c9140
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
943f344
to
9d8546b
Compare
nyoungbq
approved these changes
May 2, 2024
|
@JDuffeyBQ @mmarineBlueQuartz @nyoungbq Did we want to actually do something more with this as in changing the API? Otherwise I'll rename the PR to something like "Updating error message" |
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
09d289b
to
c9c2cf3
Compare
|
@imikejackson I'm gonna be honest, it's been a while, so I don't really remember exactly what API this PR was aiming to fix in the first place. However, if the point is percolating errors up the call tree as the description suggests then I think it's a good idea to go further with this, since it will be easier to debug and more stable. |
|
I think there was some early discussion on slack about this. But, yes, I think the issue is that the error should be percolated up the call chain instead of just crashing at runtime. Either that or every call that uses this API should be put inside of a try-catch in order to not crash. |
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
3 times, most recently
from
1425cc2
to
e15f583
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
2 times, most recently
from
e2f414f
to
c2b4b00
Compare
nyoungbq
reviewed
May 24, 2024
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
c2b4b00
to
643a8c1
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
2 times, most recently
from
62c1ebf
to
5f22eee
Compare
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
5f22eee
to
da2e463
Compare
imikejackson
changed the title
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
da2e463
to
49e98a7
Compare
We need to be able to report errors back up the call tree if possible. Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: Nathan Young <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/deep_copy_failures
branch
from
49e98a7
to
7f302ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to report errors back up the call tree if possible.