Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript check to the CI #4

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add typescript check to the CI #4

merged 1 commit into from
Jul 14, 2023

Conversation

limpbrains
Copy link
Collaborator

  • fix types
  • add type check to github/actions

@limpbrains limpbrains force-pushed the josibake-add-bip352-test-vectors branch 5 times, most recently from f495f0e to 1f4962d Compare July 12, 2023 12:20
@limpbrains
Copy link
Collaborator Author

No idea why github actions are not running, probably some settings are missing in repo confg
¯_(ツ)_/¯

@Overtorment
Copy link
Member

i needed topress this magic button

image

@limpbrains limpbrains force-pushed the josibake-add-bip352-test-vectors branch from 1f4962d to 972156e Compare July 14, 2023 10:52
@limpbrains limpbrains marked this pull request as ready for review July 14, 2023 10:55
@limpbrains
Copy link
Collaborator Author

i needed topress this magic button

Can you enable it by default? I guess there are no secrets in this repos env variables

@Overtorment
Copy link
Member

i can only change to this

image

Overtorment
Overtorment approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Overtorment Overtorment merged commit 473bc72 into BlueWallet:master Jul 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Overtorment Overtorment Overtorment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limpbrains @Overtorment