Fix $blueprint functions to do what they're expected #111
Conversation
| @@ -247,7 +282,7 @@ public function extensions(): Collection | |||
| try { | |||
| $conf = Yaml::parse($this->fileRead(base_path(".blueprint/extensions/$extension/private/.store/conf.yml"))); | |||
|
|
|||
| $collection->push(array_filter($conf['info'], fn ($k) => !!$k)); | |||
There was a problem hiding this comment.
why? info is more than enough
There was a problem hiding this comment.
I have an idea for an extension that would eventually require more than just the info tab.
But also just to do what it says. The method isn't for getting the info section, it's for getting the config
…-framework into fix/$blueprint-functions
| @@ -77,7 +77,7 @@ public function collect(): array | |||
|
|
|||
| 'blueprint' => [ | |||
| 'version' => $this->placeholderService->version(), | |||
| 'extensions' => $this->blueprint->extensions()->toArray(), | |||
| 'extensions' => $this->blueprint->extensionsConfigs()->toArray(), | |||
There was a problem hiding this comment.
this sends the entire config which is invalid, only info needs to be send (map the data)
There was a problem hiding this comment.
I'll fix it, but I'm curious. What does the API use the entire info section for?
There was a problem hiding this comment.
to keep track of usage statistics/versions
There was a problem hiding this comment.
There was a problem hiding this comment.
Should be fixed x2. That or I'm being very silly.
And add methods for current behavior