Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change templates #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change templates #3

wants to merge 3 commits into from

Conversation

jameswilson
Copy link
Member

@jameswilson jameswilson commented Jul 14, 2017 •
edited
Loading

This PR does the following:

  • RESTORE: Restore the templates to the format they used before (need commit hash reference here) including:
    • replace curly braces around if statements with <?php if (...) : ?> and <?php endif; ?>
    • pull out HTML tags outside of the embedded PHP where possible.
  • QUICKFIX: Fix punctuation around 'query time'
  • FEATURE: Allow hiding various result elements in the template via preprocess variables: Thumb link, sidebar facet h2 title, top/bottom pager, HTML full text and PDF full text links, search limiters.
  • REFACTOR: Move variable preparations out of template preprocess.
  • PERFORMANCE: Leverage Drupal core's static caching functionality (drupal_static) to avoid global variables and costly re-instantiation of the EBSCODocument object.
    • current status: INCOMPLETE, seems to have been done for only one case, but there are still usages of the global variable throughout the code. This needs to be pulled out and worked on in a separate commit.
  • SYNTAX: Code cleanup & pass Coder tests.

fran and others added 3 commits July 14, 2017 12:38
@fran @jameswilson
Update main templates (results and side facets) and remove preprocess
847e930 
* Modify ebsco.module removing template_preprocess
* Create new callbacks to allow get the search output (initializing
theme variables on it)
* Add fast cache using drupal_static to avoid initialize (it is needed
in new callbacks)
* Add new conditional in templates based on new passed parameters.
@jameswilson
Fix punctuation around 'query time'
39f813a
@fran
Changes related to theme variables and template
0d15407 
* remove conditional sentence to display top pager
* Remove theme variables and add function to set a better number format
  in search result count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameswilson @fran