Better binary artifacts WebDAV compliance #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting RFC 4918: A PUT that would result in the creation of a resource without an appropriately scoped parent collection MUST fail with a 409 (Conflict). So far, Bob incorrectly assumed that the parent directories are created automatically (e.g. on Nginx via "create_full_put_path on"). Instead of assuming such non-compliant behavior, always do an MKCOL request for the parent directory first. Even though this implies a full server round trip, its overhead should pale in comparison of pushing a big file to the server only to get an HTTP 409 at the end.
WebDAV requires that parent directories are not created implicitly. Instead, a 409 status code shall be returned to indicate that the parent collection is missing.
The code does not support FTP uploads. Instead of failing badly, issue a proper error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not assume that parent directories are created implicitly.