-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Mediaplayer remake && refactor: added ktfmt #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BobbyESP
wants to merge
17
commits into
master
Choose a base branch
from
mediaplayer_remake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r MediaStorePageViewModel
refactor: moved ConcurrentList to `:core-utilities` module
…usic data handling
This was referenced Feb 24, 2025
…ure and clarity refactor: Renamed DestinationInfo to NavigatorInfo
…ure and clarity refactor: Renamed DestinationInfo to NavigatorInfo
(refactor/crashhandler) Improved documentation
…ting feat(Build): Update Gradle and Android Gradle Plugin versions refactor(App): Update compileSdk and targetSdk to 36 fix(UI): Use LocalOverscrollFactory for PullToRefreshLayout fix(Utilities): Add ExperimentalTime annotation to getZuluTimeSnapshot chore: Update taglib dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the
app/mediaplayermodule, including dependency updates, new services, and repository implementations. The changes are primarily focused on improving the media player functionality and adding new capabilities for media scanning and playback services.Dependency and Plugin Updates:
ktfmtplugin toapp/build.gradle.ktsandapp/mediaplayer/build.gradle.ktsfor Kotlin code formatting. [1] [2]core-utilitiesmodule as a dependency inapp/build.gradle.ktsandapp/mediaplayer/build.gradle.kts. [1] [2]Media Player Enhancements:
AndroidManifest.xmlto include the newPlaybackServiceand the required permissions for media playback.PlaybackServiceto handle media playback using ExoPlayer and MediaLibraryService.MediaPlayerModule.ktto use the newPlaybackServiceand simplified dependency injection.Repository Implementations:
MediaStoreFolderScannerImplfor scanning custom folders and forcing MediaStore to scan specified folders.MusicScannerImplfor querying and observing the music library using MediaStore.New Enums:
AudioChannelsenum to represent different audio channel configurations.MediaStoreSearchFilterenum to facilitate filtering in MediaStore queries.