Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to install and run Pombo, i discovered some issues which are fixed in this PR.
Note: ubuntu 18.04 python 3.8.0
1 - install.sh and uninstall.sh scripts for linux uses #!/bin/sh -e
running the shell script with -e option abort script at first error. If some dependancies are missing, the error code 0 is generated by test=$(which ${package}) and the script is immediatly stopped without any information about the missing package
proposal : install.sh and uninstall.sh scripts must uses #!/bin/sh
2 - in install.sh command ‘python check-imports.py’ is not working: wrong path given
proposal : compute variable ${src_dir} corresponding to pombo main dir, uses this ${src_dir} everywhere it is needed
${src_dir}/tools/check-imports.py
3 - Which python version is used ??
Using multiple versions for python2 as well as for python3 on a system (this was the case for me) may lead to confusion (for which python version a missing package should be installed?). In some case, the shell script can use a different version then the terminal command.
Proposal : install script now display python version used by install.sh (version which will be used by all shell scripts)
4 - Webcam shot using streamer under Ubuntu 18.04 issue
Using option ‘-w 3’ on my computer always give a dark image (it seems webcam don’t have enough time to adjust brightness). Is this bug related to my config ? I didnt’t found any reference nor correction to this issue. Replacing ‘w 3’ with ‘-t 1 r 2’ (take 1 frame, 2 frames per second) corrects this. Corresponding options have been added for Linux in pombo.conf
; [L] /usr/bin/streamer -q -t 1 -r 2 -o
; [L] /usr/bin/streamer -q -t 1 -r 2 -j 100 -s 640x480 -o
5 - Pombo.py don’t generate the .gpg crypted file
Pombo.py line 702: in generating gpg crypted file (-o) and [files] (after -e ie input file) arguments where exchanged.