Fix #656 -- Add Python 3.13 support #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`threading.Thread` received a new `_handle` attribute in Python 3.13, which clashes with dramatiq's `_CtypesTimeoutManager(Thread)` class. This commit renames the dramatiq method to resolve the conflict. It also adds Python 3.13 to CI and package classification
amureki
force-pushed
the
656/python-313-support
branch
from
94dcb33
to
0830aa7
Compare
7 tasks
|
Thanks! |
|
shouldn't it also be in tox.ini? |
Hm, interesting catch! And the GitHub CI matrix is actually running Python tests. So, tox Python environments are serving local testing. @Bogdanp what would you say? |
|
I think it's probably fine to keep the tox config, even if it's not used in CI. I do still use it locally to test things every now and then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threading.Threadreceived a new_handleattribute in Python 3.13, which clashes with dramatiq's_CtypesTimeoutManager(Thread)class. This commit renames the dramatiq method to resolve the conflict.It also adds Python 3.13 to CI and package classification.