use existing filter to remove bgseo robots output #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see comment on [BoldGrid/boldgrid-seo#19](BoldGrid/boldgrid-seo#19) for reference. This uses the preexisting filter in bgseo to remove the robots output instead of adding a new filter for this one off case. So the superfluous addition of `boldgrid-seo/seo/robots/run` can be reverted in bgseo repo which will help keep the existing filters on output methods unified in that plugin. There have been a few support tickets where filters in boldgrid-seo were modified, and the [BoldGrid/boldgrid-seo-anspress-extension](https://github.com/BoldGrid/boldgrid-seo-anspress-extension) makes use of the filters as an officially released plugin that extends boldgrid-seo. `boldgrid-seo/seo/robots/run` was added to inspirations when implementing #49 for further reference if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see comment on BoldGrid/boldgrid-seo#19 for reference.
This uses the preexisting filter in bgseo to remove the robots output instead of adding a new filter for this one off case. So the superfluous addition of
boldgrid-seo/seo/robots/runcan be reverted in bgseo repo which will help keep the existing filters on output methods unified in that plugin. There have been a few support tickets where filters in boldgrid-seo were modified, and the BoldGrid/boldgrid-seo-anspress-extension makes use of the filters as an officially released plugin that extends boldgrid-seo.boldgrid-seo/seo/robots/runwas added to inspirations when implementing #49 for further reference if needed.To test:
ensure that
<meta name="robots" content="noindex,follow">appears, and that there is not a duplicate<meta name="robots">output when viewing inspirations' attribution page.