Bugfix: Unable to Continue as Guest after Close Bolt OTP Modal #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SSO login button. * fix lint.
* Add SSO login endpoint. * Fix lint.
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * updates * update
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * Load Bolt account details for SSO login * updates * fix lint * update
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * Load Bolt account details for SSO login * updates * fix lint * Login SFCC Platform Account after Bolt Login- Checkout Page * updates * fix test
Remove get openid config call.
* Creat SFCC account for guest. * Add empty check * Fix lint. * Add unit test and cleanup code. * lint fix
Add get platform account endpoint.
* Clean custom fields code * fix lints
* Skip customer check. * fix lint
Remove unused OCPAI codes.
Check if SSO is enabled before login platform account.
| // eslint-disable-next-line no-undef | ||
| Bolt.getInstance().on('authorize_modal_closed', () => { | ||
| var disabledAttr = $('.submit-customer').attr('disabled'); | ||
| if (typeof disabledAttr !== 'undefined' && disabledAttr !== false) { |
There was a problem hiding this comment.
Based on this article explaining Falsy values in JS. I think it's good to use if(!disabledAttr) as condition
There was a problem hiding this comment.
Make sense, just updated
* Add SSO login button. * fix lint.
* Add SSO login endpoint. * Fix lint.
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * updates * update
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * Load Bolt account details for SSO login * updates * fix lint * update
* Store accessToken/refreshToken/refreshTokenScope/ExpireIn in SFCC * fix lint * Load Bolt account details for SSO login * updates * fix lint * Login SFCC Platform Account after Bolt Login- Checkout Page * updates * fix test
Remove get openid config call.
Add get platform account endpoint.
* Clean custom fields code * fix lints
* Skip customer check. * fix lint
Remove unused OCPAI codes.
Check if SSO is enabled before login platform account.
serenayanbolt
force-pushed
the
feature/embedded-sso
branch
from
9dfb1bc
to
c086664
Compare
* Bugfix: 'Site' is not defined * fix lint * fix unit tests
| @@ -141,6 +141,13 @@ | |||
| <externally-managed-flag>false</externally-managed-flag> | |||
| <min-length>0</min-length> | |||
| </attribute-definition> | |||
| <attribute-definition attribute-id="boltEmbeddedAccountsTokens"> | |||
There was a problem hiding this comment.
I believe this is not for this PR, right?
serenayanbolt
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1200879031426307/1205119516372383/f
The solution is to remove disabled attribute when the
authorize_modal_closedevent is triggered