-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error issues reported by phpStan level2 tool #1875
Open
thanhnd0905
wants to merge
10
commits into
master
Choose a base branch
from
refactor_code_for_phpStan_level2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
a37a068
to
36b92af
Compare
0fc839c
to
79fff75
Compare
9637195
to
68e9af2
Compare
80a1244
to
2a0b69c
Compare
Co-authored-by: thanhnd0905 <[email protected]>
179988e
to
f539841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: https://app.asana.com/0/1204419514580775/1206148918307666
There are 1598 errors when upgrade phpStan level to 2
See here: https://gist.github.com/thanhnd0905/d1dc17e8fe10d8a56e7456444b6f1943
Below are the commits for fixing all errors for each folder:
Fix error issues reported by PhpSta level2 tool in API folder
Fix error issues reported by PhpSta level2 tool in Block folder
Fix error issues reported by PhpSta level2 tool in Controller folder
Fix error issues reported by PhpSta level2 tool in Observer folder
Fix error issues reported by PhpSta level2 tool in Helper folder
Fix error issues reported by PhpSta level2 tool in Model folder
Fix error issues reported by PhpSta level2 tool in Plugin folder
Fix error issues reported by PhpSta level2 tool in ThirdPartyModules folder
#changelog Fix error issues reported by PhpSta level2 tool in API folder
Type of change
How Has This Been Tested?
Please validate that you have tested your change in at least one of the following areas:
For PR Reviewer
Checklist: