Skip to content

re-raise RayOutOfMemoryErrors; do not bubble up StopIterations #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kiko-Aumond wants to merge 4 commits into
base: master
Choose a base branch
from
Open

re-raise RayOutOfMemoryErrors; do not bubble up StopIterations #173

Kiko-Aumond wants to merge 4 commits into from

Conversation

@Kiko-Aumond
Copy link

@Kiko-Aumond Kiko-Aumond commented Jan 24, 2023

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Kiko-Aumond Kiko-Aumond requested a review from a team as a code owner January 24, 2023 21:17
@Kiko-Aumond Kiko-Aumond requested a review from a team as a code owner January 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RuofanKong RuofanKong RuofanKong approved these changes

@akanso akanso Awaiting requested review from akanso akanso is a code owner automatically assigned from BonsaiAI/ray-maintainers

@Random-Word Random-Word Awaiting requested review from Random-Word

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kiko-Aumond @RuofanKong