Check role exists before deleting

Boostport · Mar 21, 2024 · ff45dac · ff45dac
1 parent e5a0daa
commit ff45dac
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/path_roles.go b/path_roles.go
@@ -296,7 +296,12 @@ func (b *grafanaBackend) pathRolesWrite(ctx context.Context, req *logical.Reques
 }
 
 func (b *grafanaBackend) pathRolesDelete(ctx context.Context, req *logical.Request, d *framework.FieldData) (*logical.Response, error) {
-	err := req.Storage.Delete(ctx, "roles/"+d.Get("name").(string))
+	roleName := d.Get("role").(string)
+	if roleName == "" {
+		return logical.ErrorResponse("missing role"), nil
+	}
+
+	err := req.Storage.Delete(ctx, "roles/"+roleName)
 	if err != nil {
 		return nil, fmt.Errorf("error deleting grafana role: %w", err)
 	}