add view files #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
farir1408
commented
Jan 21, 2018
farir1408
commented
- Добавил основную форму приложения.
- Добавил классы для отображения информации на форме.
leshiy1295
reviewed
Jan 21, 2018
|
|
||
| void Draw::clearMap() | ||
| { | ||
| pixmap.load("./map.png"); |
There was a problem hiding this comment.
это должно быть вынесено в константу/конфигурационный файл
| return; | ||
| } | ||
|
|
||
| void Draw::drawMap() |
There was a problem hiding this comment.
если Вы явно бросаете исключение в методе, то стоит об этом явно указать в сигнатуре
| listOfPoint = new QList<QPoint>(); | ||
| draw = drawOfMainControll; | ||
| color = QColor(rand() % 255, rand() % 255, rand() % 255); | ||
| if (listOfPoint == NULL) |
There was a problem hiding this comment.
new бросает исключение в отличие от malloc
чтобы не бросал, можно передать параметр (std::nothrow)
| void clearMap(); | ||
| void getScale(double *width, double *height); | ||
| private: | ||
| QTableWidget *tblWidget; |
There was a problem hiding this comment.
имеет смысл сделать интерфейсы не зависимыми от Qt (или зависимыми, но по минимуму)
а реализацию, привязанную к Qt, вынести в cpp файл, воспользовавшись тут PIMPL идиомой
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.