Skip to content

Baml salsa HIR #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: canary
Choose a base branch
from
Open

Baml salsa HIR #2723

wants to merge 8 commits into from
+14,287 −8,394

Conversation

@antoniosarosi
Copy link
Contributor

@antoniosarosi antoniosarosi commented Nov 17, 2025

No description provided.

@vercel
Copy link

vercel bot commented Nov 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
promptfiddle Ready Ready Preview Comment Nov 19, 2025 6:03pm

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

🌿 Preview your docs: https://boundary-preview-bb0da742-cfad-49f7-b1bd-57b8464d6464.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

https://sage-backend-o958zm3yf-baml.vercel.app

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2723 will degrade performances by 30.02%

Comparing antonio/salsa-hir (6dc1224) with canary (4c9d507)

Summary

❌ 6 regressions
✅ 9 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
❌ WallTime bench_incremental_add_field 23.5 µs 30.2 µs -22.19%
❌ WallTime bench_incremental_add_new_file 23.4 µs 30.9 µs -24.15%
❌ WallTime bench_incremental_modify_function 23.7 µs 30.5 µs -22.28%
❌ WallTime bench_incremental_no_change 22.9 µs 29.6 µs -22.84%
❌ WallTime bench_lexer_only_simple 55.5 µs 79.2 µs -30.02%
❌ WallTime bench_parse_only_simple 122.6 µs 151.3 µs -18.96%

imalsogreg
imalsogreg reviewed Nov 17, 2025
View reviewed changes
baml_language/crates/baml_hir/src/item_tree.rs
//!
//! The `ItemTree` contains minimal representations of all items in a container.
//! It acts as an "invalidation barrier" - only changes to item signatures
//! cause the `ItemTree` to change, not edits to whitespace, comments, or bodies.
Copy link
Collaborator

@imalsogreg imalsogreg Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - why don't changes to bodies (does this mean function bodies) cause the function to get invalidated?

Copy link
Collaborator

@imalsogreg imalsogreg Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - function bodies are stored elsewhere apparently https://github.com/BoundaryML/baml/pull/2723/files#diff-6cdcf2d13bbd1882d24da94627a7b16e3442133c617f96c7f9d9735701814abcR117

imalsogreg
imalsogreg reviewed Nov 17, 2025
View reviewed changes
baml_language/crates/baml_hir/src/lib.rs

/// Tracked struct holding all items defined in a file.
///
/// This follows the Salsa 2022 pattern: instead of returning Vec<ItemId<'db>>
Copy link
Collaborator

@imalsogreg imalsogreg Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit - we can remove some of the redundant explanations)

Copy link
Contributor Author

@antoniosarosi antoniosarosi Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I would say we do intensive human review after we're done

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

🌿 Preview your docs: https://boundary-preview-8e642d50-8f2e-44d7-b5f0-f8be79dce489.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

https://sage-backend-b65zo9qcv-baml.vercel.app

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

🌿 Preview your docs: https://boundary-preview-76d5355b-b3c9-4f4e-9e8f-c49294a46516.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

https://sage-backend-kzhcouprn-baml.vercel.app

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

🌿 Preview your docs: https://boundary-preview-4fcfd0a1-5387-4903-a6a0-a310c21b1a48.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

https://sage-backend-m9o575k8r-baml.vercel.app

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🌿 Preview your docs: https://boundary-preview-5c04fcc6-dda4-4ca5-ac79-c071f74e94bc.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

https://sage-backend-7f99mziil-baml.vercel.app

@antoniosarosi antoniosarosi deployed to boundary-tools-dev November 19, 2025 17:47 — with GitHub Actions Active
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🌿 Preview your docs: https://boundary-preview-43050412-5f79-4004-9089-69544977f974.docs.buildwithfern.com

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

https://sage-backend-bn3fn53vp-baml.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imalsogreg imalsogreg imalsogreg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antoniosarosi @imalsogreg