Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xintong Hao #12

Open
XintongHao opened this issue Nov 13, 2017 · 0 comments
Open

Xintong Hao #12

XintongHao opened this issue Nov 13, 2017 · 0 comments

Comments

@XintongHao
Copy link

Nice job! It seems like that you guys have successfully built your website and initialized some basic functions. Meanwhile, I also found some problems in your GitHub and I hope my suggestions would make your project better!

  1. Web_UI: Webpage is nice and clear. But it needs more instructions to help users know how it works. You can add some examples and give some tutorials.

  2. Server Control: It seems that you use different kind of tools to link your database. I am just a little confused with your different "client" and "server" files. Do they have different jobs? Or some of them are new version and some are test version? It is better to have a more precise name and comment in it.

  3. Networking: No idea about the test.zip (At first I think it is the sample of the test file..). And in "client&server_simulation", I cannot open the file.zip. It just extracts again and again... In your client_v2 and server_v1, if it has already tested the files, it is better to let users know what the process looks like . Because I cannot test any file through your webpage, I totally have no idea how your app works.

4.And if you have database where store the user's profile and upload information, where is it? The login page did not return anything in the console, and you don't have other "sign up" page, so I have no idea how you manage the users. Maybe you have not done that part, that will be OK~

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant