Skip to content

chore: add changeset for cleanup patch (#54, #55) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarvelNwachukwu merged 1 commit into from
May 15, 2026
Merged

chore: add changeset for cleanup patch (#54, #55) #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/cleanup-patch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@iqai/mcp-polymarket": patch
---

Cleanup batch:

- Fix stderr log lines running together due to missing trailing newlines on init/order/market-order logs (server log output is no longer corrupted into one line)

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changeset description mentions that the fix for log lines running together applies specifically to init/order/market-order logs. However, the implementation in src/util/log.ts (line 2) adds a newline to the global log utility, which affects all logs in the application. It might be more accurate to describe this as a general fix for server logging to ensure all stderr output is properly delimited.

- Reject invalid `outcomeIndex` for negRisk redemption instead of silently defaulting to outcome 0 — prevents accidentally redeeming the losing side when the caller passes a bad value
Comment on lines +7 to +8

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is a best practice to include the pull request numbers (e.g., #54, #55) in the changeset description. This allows the Changesets CLI to automatically link these entries to the corresponding pull requests in the generated CHANGELOG.md file, providing better traceability for users.

Suggested change
- Fix stderr log lines running together due to missing trailing newlines on init/order/market-order logs (server log output is no longer corrupted into one line)
- Reject invalid `outcomeIndex` for negRisk redemption instead of silently defaulting to outcome 0 — prevents accidentally redeeming the losing side when the caller passes a bad value
- Fix stderr log lines running together due to missing trailing newlines on init/order/market-order logs (#54) (server log output is no longer corrupted into one line)
- Reject invalid `outcomeIndex` for negRisk redemption instead of silently defaulting to outcome 0 (#55) — prevents accidentally redeeming the losing side when the caller passes a bad value

- Move `shx` from `dependencies` to `devDependencies` so npm consumers don't pull it in

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While moving shx to devDependencies is a correct improvement, I noticed that package.json contains suspicious version numbers for other dependencies. Specifically, @types/node is set to ^24.9.1 (line 45) and typescript to ^5.9.3 (line 48). As of now, these versions do not exist on npm (Node.js types are currently at v22 and TypeScript is at v5.7). This will likely cause installation failures for developers. Please verify and correct these versions in package.json.

Loading