Skip to content

Update ci process#21

Merged
jmejia-brainchip merged 1 commit intomainfrom
update_ci_process
Dec 9, 2025
Merged

Update ci process#21
jmejia-brainchip merged 1 commit intomainfrom
update_ci_process

Conversation

@Dominique468
Copy link
Copy Markdown
Contributor

After numerous attempts, we obtained a fully filtered stream without adding too much complexity to the GitHub Action script.
The filtered buffers are displayed at the end of the process associated with the action: "Run model checks".

I suggest we validate this work.

Copy link
Copy Markdown
Collaborator

@ktsiknos-brainchip ktsiknos-brainchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reorganize you work for a better reviewer experience:

Comment on lines +37 to +45
if os.path.exists(model_file):
# Move this step of the YAML workflow into the Python script
# Download the file via Git LFS if necessary
# git lfs pull --include="$f" --exclude=""
subprocess.run(["git", "lfs", "pull",
"--include", model_file,"--exclude", ""],
capture_output=True)

process_model(model_file)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are able to simplify this as :

Suggested change
if os.path.exists(model_file):
# Move this step of the YAML workflow into the Python script
# Download the file via Git LFS if necessary
# git lfs pull --include="$f" --exclude=""
subprocess.run(["git", "lfs", "pull",
"--include", model_file,"--exclude", ""],
capture_output=True)
process_model(model_file)
process_model(model_file)

To avoid to change the previous script approach

done <<< "${{ steps.find_files.outputs.files }}"

FILES="${{ steps.find_files.outputs.files }}"
python CI/post_filter.py -- CI/check_model.py --models $FILES
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add git ls before to run the script

git lfs pull --include $FILES --exclude ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this could be work: git lfs fsck --pointers BASE..HEAD

abih-brainchip
abih-brainchip previously approved these changes Dec 8, 2025
@Dominique468
Copy link
Copy Markdown
Contributor Author

All change requests have been processed.
Johan, you should be able to test your models as before, with a complete reduction in unwanted messages.

Maintenance and development: If new messages appear in new versions of TensorFlow, CUDA, CUDD, etc., please extend the list of regular expressions for allow and deny in CI/post_filter.py.

@jmejia-brainchip jmejia-brainchip merged commit 8aecb13 into main Dec 9, 2025
1 check passed
@jmejia-brainchip jmejia-brainchip deleted the update_ci_process branch December 9, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants