refactor: change s_base to baseMVA

Breakthrough-Energy · Apr 4, 2022 · eabc0e6 · eabc0e6
1 parent e568dbb
commit eabc0e6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/prereise/gather/griddata/hifld/const.py b/prereise/gather/griddata/hifld/const.py
@@ -1,4 +1,4 @@
-s_base = 100  # MVA
+baseMVA = 100  # noqa: N816. apparent power base for per-unit calculations
 
 mile_to_meter = 1609.34
 meter_to_mile = 1.0 / mile_to_meter

diff --git a/prereise/gather/griddata/hifld/data_process/tests/test_transmission.py b/prereise/gather/griddata/hifld/data_process/tests/test_transmission.py
@@ -200,11 +200,11 @@ def test_estimate_branch_impedance_lines():
         {"VOLTAGE": [69, 70, 345], "type": ["Line"] * 3, "Line": fake_lines}
     )
     x = estimate_branch_impedance(branch.iloc[0], pd.Series())
-    assert x == reactance / (69**2 / const.s_base)
+    assert x == reactance / (69**2 / const.baseMVA)
     x = estimate_branch_impedance(branch.iloc[1], pd.Series())
-    assert x == reactance / (70**2 / const.s_base)
+    assert x == reactance / (70**2 / const.baseMVA)
     x = estimate_branch_impedance(branch.iloc[2], pd.Series())
-    assert x == reactance / (345**2 / const.s_base)
+    assert x == reactance / (345**2 / const.baseMVA)
 
 
 def test_estimate_branch_impedance_transformers():

diff --git a/prereise/gather/griddata/hifld/data_process/transmission.py b/prereise/gather/griddata/hifld/data_process/transmission.py
@@ -672,7 +672,7 @@ def _euclidian(a, b):
         )
         return const.transformer_reactance[closest_voltage_tuple]
     elif branch.loc["type"] == "Line":
-        z_base = calculate_z_base(v_base=branch["VOLTAGE"], s_base=const.s_base)
+        z_base = calculate_z_base(v_base=branch["VOLTAGE"], s_base=const.baseMVA)
         return translate_to_per_unit(branch["Line"].series_impedance.imag, "x", z_base)
     else:
         raise ValueError(f"{branch.loc['type']} not a valid branch type")