Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry setup when iDRAC is unreachable during HA boot #21

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

PocketMiner82
Copy link
Contributor

@PocketMiner82 PocketMiner82 commented Jun 23, 2024

fixes #17

Changed:

Breaking Changes:

  • Changed UUIDs to be dependent on the fan and thermal MemberId rather than index in for loop, the order of the fans could change and therefore the entities could sometimes get mixed up, this will require a re-adding of the integration (remove integration, reboot, setup integration again)

I tested the following scenarios with a PowerEdge R630:

  • When Home Assistant starts and iDRAC is not reachable: integration waits until iDRAC becomes reachable, then displays the values correctly
  • When iDRAC becomes unreachable, after Home Assistant is started and the integration already registered the entities: The entities become unavailable. When iDRAC becomes reachable again, the values get displayed correctly again

…and available if device becomes reachable again)
@PocketMiner82 PocketMiner82 marked this pull request as ready for review June 24, 2024 17:55
@PocketMiner82
Copy link
Contributor Author

I just noticed, that the values still get mixed up sometimes, will investigate...

@PocketMiner82 PocketMiner82 marked this pull request as draft June 24, 2024 18:11
@PocketMiner82 PocketMiner82 marked this pull request as ready for review June 24, 2024 18:35
@PocketMiner82
Copy link
Contributor Author

Fixed, I think.

Copy link
Owner

@Breina Breina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! Thanks :)

@Breina Breina merged commit d390204 into Breina:master Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration crashes when iDRAC is unreachable during HA boot
2 participants